Skip to content

fix(@angular/build): forward the poll and progress options to the karma build setup - #34654

Merged
dgp1130 merged 1 commit into
angular:mainfrom
MeAkib:fix/karma-build-poll-progress
Nov 6, 2026
Merged

dgp1130 merged 1 commit into
angular:mainfrom
MeAkib:fix/karma-build-poll-progress

Conversation

@MeAkib

@MeAkib MeAkib commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

The karma builder schema documents the poll and progress options, but the application build it starts never receives them: --no-progress still logs build progress and poll does not switch the file watcher to polling. The legacy webpack-based karma builder honored both options.

Forward both values to the build options. No new test since both are pass-through options; the package unit tests cover the compilation of the changed setup.

…ma build setup

The karma builder schema documents the `poll` and `progress` options, but the application build
it starts never receives them: `--no-progress` still logs build progress and `poll` does not
switch the file watcher to polling. The legacy webpack-based karma builder honored both options.

Forward both values to the build options. No new test since both are pass-through options; the
package unit tests cover the compilation of the changed setup.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Karma application builder to include the 'poll' and 'progress' options in the build setup configuration. There are no review comments, and I have no feedback to provide.

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Nov 5, 2026
@dgp1130
dgp1130 merged commit 0edb6c6 into angular:main Nov 6, 2026
42 checks passed
@dgp1130

dgp1130 commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

This PR was merged into the repository. The changes were merged into the following branches:

@MeAkib
MeAkib deleted the fix/karma-build-poll-progress branch November 7, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants